]> git.ipfire.org Git - people/ms/linux.git/commit - fs/ext4/ioctl.c
ext4: fix setattr project check in fssetxattr ioctl
authorWang Shilong <wangshilong1991@gmail.com>
Wed, 3 Oct 2018 14:33:32 +0000 (10:33 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Wed, 3 Oct 2018 14:33:32 +0000 (10:33 -0400)
commitdc7ac6c4cae3b58724c2f1e21a7c05ce19ecd5a8
tree332457b7a5a12fdc8231bfa3f962ab88dbfaebda
parentc0e3e0406a0c39044c7dc25f3386694542d50fcc
ext4: fix setattr project check in fssetxattr ioctl

Currently, project quota could be changed by fssetxattr
ioctl, and existed permission check inode_owner_or_capable()
is obviously not enough, just think that common users could
change project id of file, that could make users to
break project quota easily.

This patch try to follow same regular of xfs project
quota:

"Project Quota ID state is only allowed to change from
within the init namespace. Enforce that restriction only
if we are trying to change the quota ID state.
Everything else is allowed in user namespaces."

Besides that, check and set project id'state should
be an atomic operation, protect whole operation with
inode lock, ext4_ioctl_setproject() is only used for
ioctl EXT4_IOC_FSSETXATTR, we have held mnt_want_write_file()
before ext4_ioctl_setflags(), and ext4_ioctl_setproject()
is called after ext4_ioctl_setflags(), we could share
codes, so remove it inside ext4_ioctl_setproject().

Signed-off-by: Wang Shilong <wshilong@ddn.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Reviewed-by: Andreas Dilger <adilger@dilger.ca>
Cc: stable@kernel.org
fs/ext4/ioctl.c