]> git.ipfire.org Git - thirdparty/gcc.git/commit - gcc/omp-expand.c
openmp: Diagnose non-rectangular loops with invalid steps
authorJakub Jelinek <jakub@redhat.com>
Thu, 2 Jul 2020 09:03:33 +0000 (11:03 +0200)
committerJakub Jelinek <jakub@redhat.com>
Thu, 2 Jul 2020 09:03:33 +0000 (11:03 +0200)
commit9d50112acfc01f85fe0fb6d88b329e6122e817b3
tree3f58021fee5ef016001d29f0db4c6589e57553e7
parent6153cfd7a342f131d347de1aea87f352f3ccd4e7
openmp: Diagnose non-rectangular loops with invalid steps

THe OpenMP 5 standard requires that if some loop in OpenMP loop nest refers
to some outer loop's iterator variable, then the subtraction of the multiplication
factors for the outer iterator multiplied by the outer increment modulo the
inner increment is 0.  For loops with non-constants in any of these we can't
diagnose it, it would be a task for something like -fsanitize=openmp,
but if all these are constant, we can diagnose it.

2020-07-02  Jakub Jelinek  <jakub@redhat.com>

* omp-expand.c (expand_omp_for): Diagnose non-rectangular loops with
invalid steps - ((m2 - m1) * incr_outer) % incr must be 0 in valid
OpenMP non-rectangular loops.  Use XALLOCAVEC.

* c-c++-common/gomp/loop-7.c: New test.
gcc/omp-expand.c
gcc/testsuite/c-c++-common/gomp/loop-7.c [new file with mode: 0644]