]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commit - gdb/objfiles.c
don't share per-BFD data if relocations are needed
authorTom Tromey <tromey@redhat.com>
Mon, 7 Oct 2013 19:31:13 +0000 (19:31 +0000)
committerTom Tromey <tromey@redhat.com>
Mon, 7 Oct 2013 19:31:13 +0000 (19:31 +0000)
commit1da77581c0559e62b80b27f06f81dad4c7a7a0be
tree6ff5dc49a1c003c5b888f3f0fe32419fabcfe570
parentf44eeb117f66f09bf1ffed1cfb423f36a89ddfe6
don't share per-BFD data if relocations are needed

Right now we always share per-BFD data across objfiles, if there is a
BFD.  This works fine.  However, we're going to start sharing more
data, and sometimes this data will come directly from sections of the
BFD.  If such a section has SEC_RELOC set, then the data coming from
that section will not be truly sharable -- the section will be
program-space-dependent, and re-read by gdb for each objfile.

This patch disallows per-BFD sharing in this case.  This is a bit
"heavy" in that we could in theory examine each bit of shared data for
suitability.  However, that is more complicated, and SEC_RELOC is rare
enough that I think we needn't bother.

Note that the "no sharing" case is equivalent to "gdb works as it
historically did".  That is, the sharing is a new(-ish) optimization.

Built and regtested on x86-64 Fedora 18.

* gdb_bfd.c (struct gdb_bfd_data) <relocation_computed,
needs_relocations>: New fields.
(gdb_bfd_requires_relocations): New function.
* gdb_bfd.h (gdb_bfd_requires_relocations): Declare.
* objfiles.c (get_objfile_bfd_data): Disallow sharing if
the BFD needs relocations applied.
gdb/ChangeLog
gdb/gdb_bfd.c
gdb/gdb_bfd.h
gdb/objfiles.c