]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commit - gdb/s12z-tdep.c
gdb: move gdb_disassembly_flag into a new disasm-flags.h file
authorAndrew Burgess <aburgess@redhat.com>
Mon, 4 Apr 2022 20:07:54 +0000 (21:07 +0100)
committerAndrew Burgess <aburgess@redhat.com>
Wed, 6 Apr 2022 12:09:44 +0000 (13:09 +0100)
commitc8154ce0d6942e5988076edd674036ff384ab433
tree963c708838288216c653411d944ea3bb6b61d322
parentca028a46d51374864e4a4aa2942dfa7d93b893ce
gdb: move gdb_disassembly_flag into a new disasm-flags.h file

While working on the disassembler I was getting frustrated.  Every
time I touched disasm.h it seemed like every file in GDB would need to
be rebuilt.  Surely the disassembler can't be required by that many
parts of GDB, right?

Turns out that disasm.h is included in target.h, so pretty much every
file was being rebuilt!

The only thing from disasm.h that target.h needed is the
gdb_disassembly_flag enum, as this is part of the target_ops api.

In this commit I move gdb_disassembly_flag into its own file.  This is
then included in target.h and disasm.h, after which, the number of
files that depend on disasm.h is much reduced.

I also audited all the other includes of disasm.h and found that the
includes in mep-tdep.c and python/py-registers.c are no longer needed,
so I've removed these.

Now, after changing disasm.h, GDB rebuilds much quicker.

There should be no user visible changes after this commit.
gdb/Makefile.in
gdb/arc-linux-tdep.c
gdb/disasm-flags.h [new file with mode: 0644]
gdb/disasm.h
gdb/mep-tdep.c
gdb/python/py-registers.c
gdb/s12z-tdep.c
gdb/target.h