]> git.ipfire.org Git - thirdparty/linux.git/commit - include/linux/eventfd.h
eventfd: guard wake_up in eventfd fs calls as well
authorDylan Yudaken <dylany@fb.com>
Tue, 16 Aug 2022 13:59:59 +0000 (06:59 -0700)
committerJens Axboe <axboe@kernel.dk>
Wed, 21 Sep 2022 16:30:42 +0000 (10:30 -0600)
commit9f0deaa12d832f488500a5afe9b912e9b3cfc432
tree98e270c4c922f03493e59cd0bf64854e9b10d55f
parent521a547ced6477c54b4b0cc206000406c221b4d6
eventfd: guard wake_up in eventfd fs calls as well

Guard wakeups that the user can trigger, and that may end up triggering a
call back into eventfd_signal. This is in addition to the current approach
that only guards in eventfd_signal.

Rename in_eventfd_signal -> in_eventfd at the same time to reflect this.

Without this there would be a deadlock in the following code using libaio:

int main()
{
struct io_context *ctx = NULL;
struct iocb iocb;
struct iocb *iocbs[] = { &iocb };
int evfd;
        uint64_t val = 1;

evfd = eventfd(0, EFD_CLOEXEC);
assert(!io_setup(2, &ctx));
io_prep_poll(&iocb, evfd, POLLIN);
io_set_eventfd(&iocb, evfd);
assert(1 == io_submit(ctx, 1, iocbs));
        write(evfd, &val, 8);
}

Signed-off-by: Dylan Yudaken <dylany@fb.com>
Reviewed-by: Jens Axboe <axboe@kernel.dk>
Link: https://lore.kernel.org/r/20220816135959.1490641-1-dylany@fb.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
fs/eventfd.c
include/linux/eventfd.h
include/linux/sched.h