]> git.ipfire.org Git - thirdparty/linux.git/commit - include/linux/fs.h
dax: fix vma_is_fsdax() helper
authorDan Williams <dan.j.williams@intel.com>
Thu, 22 Feb 2018 01:08:01 +0000 (17:08 -0800)
committerDan Williams <dan.j.williams@intel.com>
Mon, 26 Feb 2018 20:32:42 +0000 (12:32 -0800)
commit230f5a8969d8345fc9bbe3683f068246cf1be4b8
treeb6df1cb9d5379fd341c1d179ebae744e96df9ebb
parent9d4949b4935831be10534d5432bf611285a572a5
dax: fix vma_is_fsdax() helper

Gerd reports that ->i_mode may contain other bits besides S_IFCHR. Use
S_ISCHR() instead. Otherwise, get_user_pages_longterm() may fail on
device-dax instances when those are meant to be explicitly allowed.

Fixes: 2bb6d2837083 ("mm: introduce get_user_pages_longterm")
Cc: <stable@vger.kernel.org>
Reported-by: Gerd Rausch <gerd.rausch@oracle.com>
Acked-by: Jane Chu <jane.chu@oracle.com>
Reported-by: Haozhong Zhang <haozhong.zhang@intel.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
include/linux/fs.h