]> git.ipfire.org Git - thirdparty/linux.git/commit - include/linux/fs.h
xfs: evict all inodes involved with log redo item
authorDarrick J. Wong <darrick.wong@oracle.com>
Sat, 19 Aug 2017 01:08:25 +0000 (18:08 -0700)
committerDarrick J. Wong <darrick.wong@oracle.com>
Fri, 1 Sep 2017 17:55:30 +0000 (10:55 -0700)
commit799ea9e9c59949008770aab4e1da87f10e99dbe4
treea61a76330a6c6a1a45139df2afa9d2b4b2aee6fa
parent2d32311cf19bfb8c1d2b4601974ddd951f9cfd0b
xfs: evict all inodes involved with log redo item

When we introduced the bmap redo log items, we set MS_ACTIVE on the
mountpoint and XFS_IRECOVERY on the inode to prevent unlinked inodes
from being truncated prematurely during log recovery.  This also had the
effect of putting linked inodes on the lru instead of evicting them.

Unfortunately, we neglected to find all those unreferenced lru inodes
and evict them after finishing log recovery, which means that we leak
them if anything goes wrong in the rest of xfs_mountfs, because the lru
is only cleaned out on unmount.

Therefore, evict unreferenced inodes in the lru list immediately
after clearing MS_ACTIVE.

Fixes: 17c12bcd30 ("xfs: when replaying bmap operations, don't let unlinked inodes get reaped")
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Cc: viro@ZenIV.linux.org.uk
Reviewed-by: Brian Foster <bfoster@redhat.com>
fs/inode.c
fs/internal.h
fs/xfs/xfs_log.c
include/linux/fs.h