]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit - include/linux/splice.h
fs: fork splice_file_range() from do_splice_direct()
authorAmir Goldstein <amir73il@gmail.com>
Thu, 30 Nov 2023 14:16:22 +0000 (16:16 +0200)
committerChristian Brauner <brauner@kernel.org>
Fri, 1 Dec 2023 10:39:50 +0000 (11:39 +0100)
commit488e8f685207e0758398963d6834f81e5e61c162
tree12350afc957a74cb9861d88569fbf7a337c64179
parent21b32e6a0ab5b174fa1ca2fb4c212577cf405d83
fs: fork splice_file_range() from do_splice_direct()

In preparation of calling do_splice_direct() without file_start_write()
held, create a new helper splice_file_range(), to be called from context
of ->copy_file_range() methods instead of do_splice_direct().

Currently, the only difference is that splice_file_range() does not take
flags argument and that it asserts that file_start_write() is held, but
we factor out a common helper do_splice_direct_actor() that will be used
later.

Use the new helper from __ceph_copy_file_range(), that was incorrectly
passing to do_splice_direct() the copy flags argument as splice flags.
The value of copy flags in ceph is always 0, so it is a smenatic bug fix.

Move the declaration of both helpers to linux/splice.h.

Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Link: https://lore.kernel.org/r/20231130141624.3338942-2-amir73il@gmail.com
Acked-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Christian Brauner <brauner@kernel.org>
fs/ceph/file.c
fs/read_write.c
fs/splice.c
include/linux/fs.h
include/linux/splice.h