]> git.ipfire.org Git - thirdparty/linux.git/commit - init/Kconfig
futex: Ensure futex_atomic_cmpxchg_inatomic() is present
authorArnd Bergmann <arnd@arndb.de>
Tue, 26 Oct 2021 10:03:47 +0000 (12:03 +0200)
committerThomas Gleixner <tglx@linutronix.de>
Wed, 24 Nov 2021 23:02:28 +0000 (00:02 +0100)
commit3f2bedabb62c6210df63b604dc988d2f7f56f947
treefb2f5f27895a06bb5c2a2de7784f991b64375e46
parent2202e15b2b1a946ce760d96748cd7477589701ab
futex: Ensure futex_atomic_cmpxchg_inatomic() is present

The boot-time detection of futex_atomic_cmpxchg_inatomic() has a bug on
some 32-bit arm builds, and Thomas Gleixner suggested that setting
CONFIG_HAVE_FUTEX_CMPXCHG would avoid the problem, as it is always present
anyway.

Looking into which other architectures could do the same showed that almost
all architectures have it, the exceptions being:

 - some old 32-bit MIPS uniprocessor cores without ll/sc
 - one xtensa variant with no SMP
 - 32-bit SPARC when built for SMP

Fix MIPS And Xtensa by rearranging the generic code to let it be used
as a fallback.

For SPARC, the SMP definition just ends up turning off futex anyway, so
this can be done at Kconfig time instead. Note that sparc32 glibc requires
the CASA instruction for its mutexes anyway, which is only available when
running on SPARCv9 or LEON CPUs, but needs to be implemented in the sparc32
kernel for those.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Max Filippov <jcmvbkbc@gmail.com>
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Rich Felker <dalias@libc.org>
Link: https://lore.kernel.org/r/20211026100432.1730393-1-arnd@kernel.org
arch/mips/include/asm/futex.h
arch/xtensa/include/asm/futex.h
include/asm-generic/futex.h
init/Kconfig