]> git.ipfire.org Git - thirdparty/gcc.git/commit - libiberty/ChangeLog
Fix demangler testsuite crashes with CP_DEMANGLE_DEBUG defined
authorpalves <palves@138bc75d-0d04-0410-961f-82ee72b054a4>
Wed, 28 May 2014 21:55:41 +0000 (21:55 +0000)
committerpalves <palves@138bc75d-0d04-0410-961f-82ee72b054a4>
Wed, 28 May 2014 21:55:41 +0000 (21:55 +0000)
commit61b1440327acebe3aebb7bca187df4abafbf3179
treee19defa1e850831a55ee81c911579554676c74c7
parent7f9463ecb4e1285d80975224aff4d71e7a64bc2e
Fix demangler testsuite crashes with CP_DEMANGLE_DEBUG defined

Running the demangler's testsuite with CP_DEMANGLE_DEBUG defined
crashes, with:

 Program received signal SIGSEGV, Segmentation fault.
 0x000000000040a8c3 in d_dump (dc=0x1, indent=12) at ../../src/libiberty/cp-demangle.c:567
 567       switch (dc->type)

 (gdb) bt 3
 #0  0x000000000040a8c3 in d_dump (dc=0x1, indent=12) at ../../src/libiberty/cp-demangle.c:567
 #1  0x000000000040ae47 in d_dump (dc=0x7fffffffd098, indent=10) at ../../src/libiberty/cp-demangle.c:787
 #2  0x000000000040ae47 in d_dump (dc=0x7fffffffd0c8, indent=8) at ../../src/libiberty/cp-demangle.c:787

Note dc=0x1, which is obviously a bogus pointer.  This is the end of
d_dump recursing for a component type that that doesn't actually have
subtrees:

 787       d_dump (d_left (dc), indent + 2);
 788       d_dump (d_right (dc), indent + 2);

This fixes the two cases the testsuite currently trips on.

libiberty/
2014-05-28  Pedro Alves  <palves@redhat.com>

* cp-demangle.c (d_dump): Handle DEMANGLE_COMPONENT_FUNCTION_PARAM
and DEMANGLE_COMPONENT_NUMBER.

git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@211035 138bc75d-0d04-0410-961f-82ee72b054a4
libiberty/ChangeLog
libiberty/cp-demangle.c