]> git.ipfire.org Git - thirdparty/gcc.git/commit - libitm/ChangeLog
Fix throw specifiers on interface.
authorNathan Sidwell <nathan@acm.org>
Tue, 12 May 2020 17:54:53 +0000 (10:54 -0700)
committerNathan Sidwell <nathan@acm.org>
Tue, 12 May 2020 17:54:53 +0000 (10:54 -0700)
commitf0de5d83eecd4902e4a0447bfa4863014b6b2eaf
tree944f7e1b231934e27192db86841d55d6d8429f16
parentd17cdc17c90ce77cb90c569322c1f241d3530cec
Fix throw specifiers on interface.

I discovered that libitm:
(a) declares __cxa_allocate_exception and friends directly,
(b) doesn't mark them as 'throw()'
(c) doesn't mark the replacment fns _ITM_$foo as nothrow either

We happen to get away with it because of code in the compiler that,
although it checks the parameter types, doesn't check the exception
specification.  (One reason being they used to not be part of the
language's type system, but now they are.)  I suspect this can lead us
to generate pessimal code later, if we've seen one of these decls
earlier.  Anyway, with modules it becomes trickier[*], so I'm trying
to clean it up and not be a problem.  I see Jakub fixed part of the
problem
(https://gcc.gnu.org/pipermail/gcc-patches/2018-December/513302.html)
AFAICT, he did fix libitm's decls, but left the lax parm-type checking
in the compiler.

libitm.h is not very informative about specification:
  in version 1 of http://www.intel.com/some/path/here.pdf.  */

Anyway, it was too fiddly to have libitm pick up the declarations from
libsupc++.  Besides it makes them weak declarations, and then provides
definitions for non-elf systems.  So this patch adds the expected
'throw()'

* libitm/libitm.h (_ITM_NOTHROW): Define.
(_ITM_cxa_allocate_exception, _ITM_cxa_free_exception)
(_ITM_cxa_begin_catch): Use it.
* eh_cpp.cc: Add throw() to __cxa_allocate_exception,
__cxa_free_exception, __cxa_begin_catch, __cxa_tm_cleanup,
__cxa_get_globals.
(_ITM_cxa_allocate_exception, _ITM_cxa_free_exception)
(_ITM_cxa_begin_catch): Likewise.
libitm/ChangeLog
libitm/eh_cpp.cc
libitm/libitm.h