]> git.ipfire.org Git - thirdparty/git.git/commit - list-objects-filter-options.c
list_objects_filter_copy(): deep-copy sparse_oid_name field
authorJeff King <peff@peff.net>
Thu, 8 Sep 2022 04:54:29 +0000 (00:54 -0400)
committerJunio C Hamano <gitster@pobox.com>
Thu, 8 Sep 2022 18:05:46 +0000 (11:05 -0700)
commit3fbfbbb7e3c21515a2863702734fe31bf50672fd
tree8b0e348e2be4003436ea7123160115d65da4849d
parentac8035a2affdf30f2c691ad760826d955bba0507
list_objects_filter_copy(): deep-copy sparse_oid_name field

The purpose of our copy function is to do a deep copy of each field so
that the source and destination structs become independent. We correctly
copy the filter_spec string list, but we forgot the sparse_oid_name
field. By doing a shallow copy of the pointer, that puts us at risk for
a use-after-free if one or both of the structs is cleaned up.

I don't think this can be triggered in practice, because we tend to leak
the structs rather than actually clean them up. But this should
future-proof us for plugging those leaks.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
list-objects-filter-options.c