]> git.ipfire.org Git - thirdparty/glibc.git/commit - math/w_ilogb.c
Fix ilogb exception and errno (bug 6794)
authorAdhemerval Zanella <azanella@linux.vnet.ibm.com>
Wed, 11 Apr 2012 19:30:13 +0000 (16:30 -0300)
committerAndreas Jaeger <aj@suse.de>
Tue, 17 Apr 2012 20:12:53 +0000 (22:12 +0200)
commit76da7265320010c7a273ed99f53938c0f32d5fad
treef094871a5f38652d2d320a11423fee602a8746e6
parent0396e69dbefb3630651d93e0a7526c4326a071bb
Fix ilogb exception and errno (bug 6794)

[BZ #6794]
Following Joseph comments about bug 6794, here is a proposed fix. It turned out
to be a large fix mainly because I had to move some file along to follow libm
files/names conventions.

Basically I have added wrappers (w_ilogb.c, w_ilogbf.c, w_ilogbl.c) that now calls
the symbol '__ieee754_ilogb'. The wrappers checks for '__ieee754_ilogb' output and
set the errno and raise exceptions as expected.

The '__ieee754_ilogb' is implemented in sysdeps. I have moved the 's_ilogb[f|l]' files
to e_ilogb[f|l] and renamed the '__ilogb[f|l]' to '__ieee754_ilogb[f|l]'.

I also found out a bug in i386 and x86-64 assembly coded ilogb implementation where
it raises a FE_DIVBYZERO when argument is '0.0'. I corrected this issue as well.

Finally I added the errno and FE_INVALID tests for 0.0, NaN and +-InF argument. Tested
on i386, x86-64, ppc32 and ppc64.
17 files changed:
ChangeLog
NEWS
math/Makefile
math/libm-test.inc
math/w_ilogb.c [new file with mode: 0644]
math/w_ilogbf.c [new file with mode: 0644]
math/w_ilogbl.c [new file with mode: 0644]
sysdeps/generic/math_private.h
sysdeps/i386/fpu/e_ilogb.S [moved from sysdeps/i386/fpu/s_ilogb.S with 75% similarity]
sysdeps/i386/fpu/e_ilogbf.S [moved from sysdeps/i386/fpu/s_ilogbf.S with 75% similarity]
sysdeps/i386/fpu/e_ilogbl.S [moved from sysdeps/i386/fpu/s_ilogbl.S with 75% similarity]
sysdeps/ieee754/dbl-64/e_ilogb.c [moved from sysdeps/ieee754/dbl-64/s_ilogb.c with 90% similarity]
sysdeps/ieee754/flt-32/e_ilogbf.c [moved from sysdeps/ieee754/flt-32/s_ilogbf.c with 93% similarity]
sysdeps/ieee754/ldbl-128ibm/e_ilogbl.c [moved from sysdeps/ieee754/ldbl-128ibm/s_ilogbl.c with 95% similarity]
sysdeps/ieee754/ldbl-opt/w_ilogb.c [moved from sysdeps/ieee754/ldbl-opt/s_ilogb.c with 73% similarity]
sysdeps/ieee754/ldbl-opt/w_ilogbl.c [new file with mode: 0644]
sysdeps/x86_64/fpu/e_ilogbl.S [moved from sysdeps/x86_64/fpu/s_ilogbl.S with 74% similarity]