]> git.ipfire.org Git - thirdparty/git.git/commit - merge-recursive.c
merge-recursive: use subtraction to flip stage
authorJunio C Hamano <gitster@pobox.com>
Sat, 25 Jan 2020 23:57:45 +0000 (18:57 -0500)
committerJunio C Hamano <gitster@pobox.com>
Mon, 27 Jan 2020 19:17:41 +0000 (11:17 -0800)
commit4c616c2ba1c176573bd1ae7c4ec3271d1f175448
treeb5c6c4ef5f8a8eef6518a0623ef498be9551e3eb
parentee798742bd35d88770e4ef05a7944b5783790e60
merge-recursive: use subtraction to flip stage

The flip_stage() helper uses a bit-flipping xor to switch between "2"
and "3". While clever, this relies on a property of those two numbers
that is mostly coincidence. Let's write it as a subtraction; that's more
clear and would extend to other numbers if somebody copies the logic.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
merge-recursive.c