]> git.ipfire.org Git - thirdparty/linux.git/commit - mm/memory.c
Revert "MIPS: make userspace mapping young by default"
authorThomas Bogendoerfer <tsbogend@alpha.franken.de>
Sat, 5 Jun 2021 03:01:08 +0000 (20:01 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Sat, 5 Jun 2021 15:58:11 +0000 (08:58 -0700)
commit50c25ee97cf6ab011542167ab590c17012cea4ed
tree571006f986d833981d1a4f162baf2a55e4eb3d4f
parent16f0596fc1d78a1f3ae4628cff962bb297dc908c
Revert "MIPS: make userspace mapping young by default"

This reverts commit f685a533a7fab35c5d069dcd663f59c8e4171a75.

The MIPS cache flush logic needs to know whether the mapping was already
established to decide how to flush caches.  This is done by checking the
valid bit in the PTE.  The commit above breaks this logic by setting the
valid in the PTE in new mappings, which causes kernel crashes.

Link: https://lkml.kernel.org/r/20210526094335.92948-1-tsbogend@alpha.franken.de
Fixes: f685a533a7f ("MIPS: make userspace mapping young by default")
Reported-by: Zhou Yanjie <zhouyanjie@wanyeetech.com>
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: Huang Pei <huangpei@loongson.cn>
Cc: Nicholas Piggin <npiggin@gmail.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
arch/mips/mm/cache.c
include/linux/pgtable.h
mm/memory.c