]> git.ipfire.org Git - thirdparty/linux.git/commit - mm/mempolicy.c
mm/mprotect: drop pgprot_t parameter from change_protection()
authorDavid Hildenbrand <david@redhat.com>
Fri, 23 Dec 2022 15:56:16 +0000 (16:56 +0100)
committerAndrew Morton <akpm@linux-foundation.org>
Thu, 19 Jan 2023 01:12:50 +0000 (17:12 -0800)
commit1ef488edd6c4d447784710974f049628c2890481
treea3577746e57294945403990ca3dd33a9a0986ee4
parent931298e103c228c4ce6d13e7b5781aeaaff37ac7
mm/mprotect: drop pgprot_t parameter from change_protection()

Being able to provide a custom protection opens the door for
inconsistencies and BUGs: for example, accidentally allowing for more
permissions than desired by other mechanisms (e.g., softdirty tracking).
vma->vm_page_prot should be the single source of truth.

Only PROT_NUMA is special: there is no way we can erroneously allow
for more permissions when removing all permissions. Special-case using
the MM_CP_PROT_NUMA flag.

[david@redhat.com: PAGE_NONE might not be defined without CONFIG_NUMA_BALANCING]
Link: https://lkml.kernel.org/r/5084ff1c-ebb3-f918-6a60-bacabf550a88@redhat.com
Link: https://lkml.kernel.org/r/20221223155616.297723-3-david@redhat.com
Signed-off-by: David Hildenbrand <david@redhat.com>
Cc: Andrea Arcangeli <aarcange@redhat.com>
Cc: Hugh Dickins <hughd@google.com>
Cc: Nadav Amit <nadav.amit@gmail.com>
Cc: Peter Xu <peterx@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
include/linux/mm.h
mm/mempolicy.c
mm/mprotect.c
mm/userfaultfd.c