]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit - mm/percpu-km.c
percpu: convert spin_lock_irq to spin_lock_irqsave.
authorDennis Zhou <dennis@kernel.org>
Tue, 18 Dec 2018 16:42:27 +0000 (08:42 -0800)
committerDennis Zhou <dennis@kernel.org>
Tue, 18 Dec 2018 17:04:08 +0000 (09:04 -0800)
commit6ab7d47bcbf0144a8cb81536c2cead4cde18acfe
tree600747ab67a2dafdf9375bc1933ff2ba55dcb9be
parent7566ec393f4161572ba6f11ad5171fd5d59b0fbd
percpu: convert spin_lock_irq to spin_lock_irqsave.

From Michael Cree:
  "Bisection lead to commit b38d08f3181c ("percpu: restructure
   locking") as being the cause of lockups at initial boot on
   the kernel built for generic Alpha.

   On a suggestion by Tejun Heo that:

   So, the only thing I can think of is that it's calling
   spin_unlock_irq() while irq handling isn't set up yet.
   Can you please try the followings?

   1. Convert all spin_[un]lock_irq() to
      spin_lock_irqsave/unlock_irqrestore()."

Fixes: b38d08f3181c ("percpu: restructure locking")
Reported-and-tested-by: Michael Cree <mcree@orcon.net.nz>
Acked-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Dennis Zhou <dennis@kernel.org>
mm/percpu-km.c