]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit - net/sched/cls_bpf.c
bpf, cls: consolidate prog deletion path
authorDaniel Borkmann <daniel@iogearbox.net>
Sun, 4 Dec 2016 22:19:40 +0000 (23:19 +0100)
committerDavid S. Miller <davem@davemloft.net>
Mon, 5 Dec 2016 20:33:10 +0000 (15:33 -0500)
commit8d829bdb97dc3a0c9c8090b9b168ca46ea99c8d8
tree4deaf4dfba72008674fb3718e01699c89b8f8ad8
parent1afaf661b20a075a22eef3332db187001a334b81
bpf, cls: consolidate prog deletion path

Commit 18cdb37ebf4c ("net: sched: do not use tcf_proto 'tp' argument from
call_rcu") removed the last usage of tp from cls_bpf_delete_prog(), so also
remove it from the function as argument to not give a wrong impression. tp
is illegal to access from this callback, since it could already have been
freed.

Refactor the deletion code a bit, so that cls_bpf_destroy() can call into
the same code for prog deletion as cls_bpf_delete() op, instead of having
it unnecessarily duplicated.

Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Alexei Starovoitov <ast@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/cls_bpf.c