]> git.ipfire.org Git - thirdparty/qemu.git/commit - qemu-img.c
qemu-img: fix info --backing-chain --image-opts
authorStefan Hajnoczi <stefanha@redhat.com>
Thu, 5 Dec 2019 13:46:46 +0000 (13:46 +0000)
committerKevin Wolf <kwolf@redhat.com>
Wed, 18 Dec 2019 10:20:57 +0000 (11:20 +0100)
commit0da7d13a4c2ff8ac40aeb1bd24c5564c82624555
tree581f9e37bbbcfb0c63cd66334e03760d2155bd77
parentecaf647f300d69271c245a67adca9c3a89d9463a
qemu-img: fix info --backing-chain --image-opts

Only apply --image-opts to the topmost image when listing an entire
backing chain.  It is incorrect to treat backing filenames as image
options.  Assuming we have the backing chain t.IMGFMT.base <-
t.IMGFMT.mid <- t.IMGFMT, qemu-img info fails as follows:

  $ qemu-img info --backing-chain --image-opts \
      driver=qcow2,file.driver=file,file.filename=t.IMGFMT
  qemu-img: Could not open 'TEST_DIR/t.IMGFMT.mid': Cannot find device=TEST_DIR/t.IMGFMT.mid nor node_name=TEST_DIR/t.IMGFMT.mid

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Alberto Garcia <berto@igalia.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
qemu-img.c
tests/qemu-iotests/279 [new file with mode: 0755]
tests/qemu-iotests/279.out [new file with mode: 0644]
tests/qemu-iotests/group