]> git.ipfire.org Git - thirdparty/qemu.git/commit - qemu-io-cmds.c
qemu-io: Switch 'map' output to byte-based reporting
authorEric Blake <eblake@redhat.com>
Sat, 29 Apr 2017 19:14:13 +0000 (14:14 -0500)
committerMax Reitz <mreitz@redhat.com>
Thu, 11 May 2017 12:28:06 +0000 (14:28 +0200)
commit6f3c90af3c50d4f839849c8ba9b6ba4e9a548c28
treec2f260ee40006037ba2c7da3b4427106d4bc625b
parent4401fdc77cb6d79e53ce2fc2193444cad8b95749
qemu-io: Switch 'map' output to byte-based reporting

Mixing byte offset and sector allocation counts is a bit
confusing.  Also, reporting n/m sectors, where m decreases
according to the remaining size of the file, isn't really
adding any useful information; and reporting an offset at
both the front and end of the line, with large amounts of
whitespace, is pointless.  Update the output to use byte
counts and shorter lines, then adjust the affected tests
(./check -qcow2 102, ./check -vpc 146).

Note that 'qemu-io map' is MUCH weaker than 'qemu-img map';
the former only shows which regions of the active layer are
allocated, without regards to where the allocation comes from
or whether the allocated portion is known to read as zero
(because it is using the weaker bdrv_is_allocated()); while the
latter (especially in --output=json mode) reports more details
from bdrv_get_block_status().

Signed-off-by: Eric Blake <eblake@redhat.com>
Message-id: 20170429191419.30051-4-eblake@redhat.com
Reviewed-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
qemu-io-cmds.c
tests/qemu-iotests/102.out
tests/qemu-iotests/146.out