]> git.ipfire.org Git - thirdparty/glibc.git/commit - resolv/res_hconf.h
Fix incorrect double-checked locking related to _res_hconf.initialized.
authorTorvald Riegel <triegel@redhat.com>
Wed, 17 Aug 2016 11:56:11 +0000 (13:56 +0200)
committerTorvald Riegel <triegel@redhat.com>
Thu, 18 Aug 2016 18:53:37 +0000 (20:53 +0200)
commit6f9d4f595e4073807ad0e844cbb3b3d7158b76d5
treed0064a3e11f1326fcdfcad1b239076044da9a762
parentb65f0b7b2ecd144800830633a4c2719f11775572
Fix incorrect double-checked locking related to _res_hconf.initialized.

_res_hconf.initialized was not suitable for use in a multi-threaded
environment due to the lack of atomics and memory barriers.  Use of it was
also unnecessary because _res_hconf_init did the right thing by using
__libc_once.  This patch fixes the glibc-internal uses by just calling
_res_hconf_init unconditionally, and switches to a release MO atomic store
for _res_hconf.initialized to fix the glibc side of the synchronization
problem (which will maintain backward compatibility, but cannot fix the
lack of acquire MO on any glibc-external loads).

[BZ #20477]
* resolv/res_hconf.c (do_init): Use atomic access.
* resolv/res_hconf.h: Add comments.
* nscd/aicache.c (addhstaiX): Call _res_hconf_init unconditionally.
* nss/getXXbyYY_r.c (REENTRANT_NAME): Likewise.
* sysdeps/posix/getaddrinfo.c (gaih_inet): Likewise.
ChangeLog
nscd/aicache.c
nss/getXXbyYY_r.c
resolv/res_hconf.c
resolv/res_hconf.h
sysdeps/posix/getaddrinfo.c