]> git.ipfire.org Git - thirdparty/qemu.git/commit - scsi/utils.c
scsi: provide general-purpose functions to manage sense data
authorPaolo Bonzini <pbonzini@redhat.com>
Mon, 27 Nov 2017 12:27:41 +0000 (13:27 +0100)
committerPaolo Bonzini <pbonzini@redhat.com>
Thu, 21 Dec 2017 08:30:32 +0000 (09:30 +0100)
commitf68d98b21fa74155dc7c1fd212474379ac3c7531
treef34fe29e9e8391e75044acffb10174e4953ae33a
parent7299e1a411de99761a4260e44b4f1cf2e4e126ef
scsi: provide general-purpose functions to manage sense data

Extract the common parts of scsi_sense_buf_to_errno, scsi_convert_sense
and scsi_target_send_command's REQUEST SENSE handling into two new
functions scsi_parse_sense_buf and scsi_build_sense_buf.

Fix a bug in scsi_target_send_command along the way; the length was
written in buf[10] rather than buf[7].

Reported-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Fixes: b07fbce634 ("scsi-bus: correct responses for INQUIRY and REQUEST SENSE")
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
hw/scsi/scsi-bus.c
include/scsi/utils.h
scsi/utils.c