]> git.ipfire.org Git - thirdparty/squid.git/commit - src/FwdState.cc
Bug 4437: Fix Segfault on Certain SSL Handshake Errors
authorChristos Tsantilas <chtsanti@users.sourceforge.net>
Sat, 13 Feb 2016 05:44:58 +0000 (18:44 +1300)
committerAmos Jeffries <squid3@treenet.co.nz>
Sat, 13 Feb 2016 05:44:58 +0000 (18:44 +1300)
commit4e6462875a9159b3a71f39914602593bbd466168
treebcf4f6a09655a22ba23c91e70b861c56d0a99f57
parent93cc83e7face7a2d85cc577a0f83034d3b9cfde5
Bug 4437: Fix Segfault on Certain SSL Handshake Errors

Squid after an unsuccesfull try to connect to the remote server may make two
concurrent retries to connect to the remote SSL server, calling twice the
FwdState::retryOrBail() method, which may result to unexpected behaviour.

Prevent this by just closing the connection to the remote SSL server inside
FwdState::connectedToPeer method on error and instead of calling the
FwdState::retryOrBail method, just allow comm_close handler to retry the
connection if required.

  This is a Measurement Factory project
src/FwdState.cc