]> git.ipfire.org Git - thirdparty/squid.git/commit - src/adaptation/icap/ModXact.cc
ICAP stalls large HTTP transactions (#414)
authorEduard Bagdasaryan <eduard.bagdasaryan@measurement-factory.com>
Thu, 6 Jun 2019 12:08:31 +0000 (12:08 +0000)
committerSquid Anubis <squid-anubis@squid-cache.org>
Sat, 8 Jun 2019 08:37:27 +0000 (08:37 +0000)
commit64df2bff6a9bab3fb0f8882a929022d53346b231
tree4197cc41309fd69d9de904428552d3118a9f2922
parentd959846ffd597bd710c5ff9f019771111fc4464b
ICAP stalls large HTTP transactions (#414)

Calling virginBodySending.plan() has nothing to do with ICAP trailers
support. These (expensive!) plans are necessary if and only if we may
echo the virgin message back to Squid.

Since 6fbd6e, ICAP code always planned to echo the virgin body, even
when no echoing was needed. Echoing requires buffering the virgin
message body, so these plans stalled responses with bodies exceeding
~65K buffer capacity when, for example, the ICAP server did not respond
until getting the entire request body.
src/adaptation/icap/ModXact.cc