]> git.ipfire.org Git - thirdparty/squid.git/commit - src/client_side.cc
bug fix: assertion failed: client_side.cc:3720: "alg && param"
authorChristos Tsantilas <chtsanti@users.sourceforge.net>
Tue, 17 Apr 2012 15:21:39 +0000 (18:21 +0300)
committerChristos Tsantilas <chtsanti@users.sourceforge.net>
Tue, 17 Apr 2012 15:21:39 +0000 (18:21 +0300)
commit8f9720ce9dc744856f97b4afa004c73dd8dd14eb
tree8e89cfda88e7cc8d4d35fbeb5ce3f8d891041272
parent4b0d23b7cc273076392251ee5ab2a72da7beacfe
bug fix: assertion failed: client_side.cc:3720: "alg && param"

Someone can hit this assertion when have two "sslproxy_cert_adapt setCommonName"
configuration lines the first with parameter but the second without parameter:
  sslproxy_cert_adapt setCommonName{toThisOne} AN_IP
  sslproxy_cert_adapt setCommonName AN_IP

Inside ConnStateData::buildSslCertGenerationParams method inside the loop
  for (sslproxy_cert_adapt *ca = Config.ssl_client.cert_adapt; ....) {...}
the second time the loop entered the param is NULL and never set because
certProperties.setCommonName is already set, so we hit the assertion.

The problem solved with removing the assertion.
src/client_side.cc