]> git.ipfire.org Git - thirdparty/squid.git/commit - src/clients/Client.cc
Two unrelated changes: A failed ICAP RESPMOD transaction could leave
authorrousskov <>
Tue, 8 May 2007 22:45:00 +0000 (22:45 +0000)
committerrousskov <>
Tue, 8 May 2007 22:45:00 +0000 (22:45 +0000)
commit0f283edf9f67a0ac7c8c68574c0a2b58073b7f47
treeea1cd50978d1aae00393087b3aeb71188d794588
parent254f3930e44c186ecd2a9b1c860ddbe9d16b183f
Two unrelated changes: A failed ICAP RESPMOD transaction could leave
the HTTP transaction stuck and a bug #1819 fix.

Change 1: After detecting an ICAP error and calling fwd->fail(),
the HTTP Server now calls abortTransaction() (and, hence,
comm_close) instead of calling closeServer() (and, hence,
fwd->unregister).  Server::closeServer() is a virtual method
that should not be called outside of Server::serverComplete().
It would be nice to enforce that somehow. Perhaps we should at
least rename closeServer?

Change 2: Bug #1819 fix: retry the ICAP transaction when its
pconn fails. The changes in this file were minor. Search
src/ICAP/ICAPXaction.cc log around v1.7 for complete details of
the bug #1819 fix.
src/Server.cc