]> git.ipfire.org Git - thirdparty/systemd.git/commit - src/core/unit.c
Remove snapshot unit type 1841/head
authorZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Sun, 8 Nov 2015 13:12:54 +0000 (14:12 +0100)
committerZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Wed, 11 Nov 2015 00:33:06 +0000 (19:33 -0500)
commit36b4a7ba555540edb7648e0f97019280b4ac38de
treea00ff6d8304552e68e08e026d7f0c174cbed5746
parente3c4a681db0b7004904b95d55fd1a443161c9397
Remove snapshot unit type

Snapshots were never useful or used for anything. Many systemd
developers that I spoke to at systemd.conf2015, didn't even know they
existed, so it is fairly safe to assume that this type can be deleted
without harm.

The fundamental problem with snapshots is that the state of the system
is dynamic, devices come and go, users log in and out, timers fire...
and restoring all units to some state from the past would "undo"
those changes, which isn't really possible.

Tested by creating a snapshot, running the new binary, and checking
that the transition did not cause errors, and the snapshot is gone,
and snapshots cannot be created anymore.

New systemctl says:
Unknown operation snapshot.
Old systemctl says:
Failed to create snapshot: Support for snapshots has been removed.

IgnoreOnSnaphost settings are warned about and ignored:
Support for option IgnoreOnSnapshot= has been removed and it is ignored

http://lists.freedesktop.org/archives/systemd-devel/2015-November/034872.html
27 files changed:
Makefile-man.am
Makefile.am
man/systemctl.xml
man/systemd.snapshot.xml [deleted file]
man/systemd.unit.xml
man/systemd.xml
po/POTFILES.skip
shell-completion/bash/systemctl.in
shell-completion/zsh/_sd_unit_files
shell-completion/zsh/_systemctl.in
src/basic/unit-name.c
src/basic/unit-name.h
src/core/dbus-manager.c
src/core/dbus-snapshot.c [deleted file]
src/core/dbus-snapshot.h [deleted file]
src/core/dbus-unit.c
src/core/device.c
src/core/load-fragment-gperf.gperf.m4
src/core/manager.h
src/core/scope.c
src/core/service.c
src/core/snapshot.c [deleted file]
src/core/snapshot.h [deleted file]
src/core/unit.c
src/core/unit.h
src/systemctl/systemctl.c
src/test/test-tables.c