]> git.ipfire.org Git - thirdparty/systemd.git/commit - src/resolve/resolved-dns-transaction.c
resolved: retry on SERVFAIL before downgrading feature level
authorSteven Siloti <ssiloti@gmail.com>
Sun, 11 Jul 2021 18:05:26 +0000 (11:05 -0700)
committerLennart Poettering <lennart@poettering.net>
Fri, 13 Aug 2021 07:23:12 +0000 (09:23 +0200)
commit8a33aa199dc1cea14494469ac9d7d08dc6721df1
treee3e776d1bebd1ecb9a7080735ba418978e061f50
parentd8151fb94916325c2ff88653aeda903c1eef7d84
resolved: retry on SERVFAIL before downgrading feature level

The SERVFAIL RCODE can be generated for many reasons which may not be related
to lack of feature support. For example, the Stubby resolver generates
SERVFAIL when a request times out. Such transient failures can cause
unnecessary downgrades to both the transaction and the server's feature level.
The consequences of this are especially severe if the server is in DNSSEC
strict mode. In this case repeated downgrades eventually cause the server to
stop resolving entirely with the error "incompatible-server".

To avoid unnecessary downgrades the request should be retried once with the
current level before the transaction's feature level is downgraded.
src/resolve/resolved-dns-server.c
src/resolve/resolved-dns-transaction.c