]> git.ipfire.org Git - thirdparty/squid.git/commit - src/ssl/helper.cc
Categorize level-0/1 messages; part 1: "easy" problem messages (#946)
authorAlex Rousskov <rousskov@measurement-factory.com>
Fri, 21 Jan 2022 04:45:11 +0000 (04:45 +0000)
committerSquid Anubis <squid-anubis@squid-cache.org>
Fri, 21 Jan 2022 06:13:01 +0000 (06:13 +0000)
commitd816f28de8ba817a98a49f9cfd88ddaa334d7aad
tree8ad36e779e032411f65d266c26189418add5e726
parentf212d11018c298fd7a940dcecc7b4030ae790bc2
Categorize level-0/1 messages; part 1: "easy" problem messages (#946)

Today, it is impractical to reliably identify important cache.log
messages in automated sysadmin notification systems. No regular
expression is guaranteed to match all important messages and none of the
unimportant ones. While message importance is naturally subjective (with
cache_log_message and notification system regexes available to customize
handling of specific messages), even reliable detection of _potentially_
important messages (to bootstrap admin customization efforts) is
impractical today. Any notification configuration is likely to miss an
important message (in today's or future code) and/or spam admins with
unimportant messages.

Fully addressing this problem requires many changes. This change lays a
foundation for that work by standardizing three well-known message
prefixes (`FATAL:`, `ERROR:`, and `WARNING:`) for debugs() messages
reporting various problems. Eventually, all problem-reporting messages
(and only those) will use one of the standard prefixes. This change
converts 300+ debugs(), bringing the total to 900+ messages using a
a standard prefix. There are more than 5'000 debugs() in Squid.

The scope of this change are problem-reporting debugs() statements that
can be detected and converted by a simple script. We also applied a few
easy-to-automate polishing touches to modified debugs(), like replacing
debug level 0 with DBG_CRITICAL, expanding some contractions (e.g.,
"can't"), and fixing grammar (e.g., "is has").
119 files changed:
src/ConfigParser.cc
src/DiskIO/DiskDaemon/DiskdFile.cc
src/DiskIO/DiskThreads/aiops.cc
src/DiskIO/DiskThreads/aiops_win32.cc
src/DiskIO/IpcIo/IpcIoFile.cc
src/DiskIO/Mmapped/MmappedFile.cc
src/EventLoop.cc
src/FwdState.cc
src/HttpHeader.cc
src/HttpRequest.cc
src/MemObject.cc
src/Notes.cc
src/StoreMeta.cc
src/WinSvc.cc
src/acl/Acl.cc
src/acl/Arp.cc
src/acl/Asn.cc
src/acl/AtStep.cc
src/acl/Eui64.cc
src/acl/FilledChecklist.cc
src/acl/Gadgets.cc
src/acl/InnerNode.cc
src/acl/IntRange.cc
src/acl/Ip.cc
src/acl/Random.cc
src/acl/TimeData.cc
src/adaptation/ServiceConfig.cc
src/adaptation/ecap/ServiceRep.cc
src/adaptation/icap/History.cc
src/adaptation/icap/ServiceRep.cc
src/adaptation/icap/Xaction.cc
src/auth/Acl.cc
src/auth/AclProxyAuth.cc
src/auth/SchemeConfig.cc
src/auth/digest/UserRequest.cc
src/base/TextException.h
src/cache_cf.cc
src/cache_manager.cc
src/client_side.cc
src/client_side_reply.cc
src/clients/Client.cc
src/clients/FtpClient.cc
src/clients/FtpGateway.cc
src/comm.cc
src/comm/ModDevPoll.cc
src/comm/ModEpoll.cc
src/comm/TcpAcceptor.cc
src/debug.cc
src/dns_internal.cc
src/errorpage.cc
src/esi/Esi.cc
src/esi/Expression.cc
src/esi/Include.cc
src/eui/Eui48.cc
src/external_acl.cc
src/format/Config.cc
src/fs/rock/RockSwapDir.cc
src/fs/ufs/RebuildState.cc
src/fs/ufs/UFSStoreState.cc
src/fs/ufs/UFSSwapDir.cc
src/fs/ufs/UFSSwapLogParser.cc
src/fs_io.cc
src/gopher.cc
src/helper.cc
src/helper/ChildConfig.cc
src/http.cc
src/http/Message.cc
src/http/StatusLine.cc
src/http/one/RequestParser.cc
src/icmp/Icmp4.cc
src/icmp/Icmp6.cc
src/icmp/IcmpPinger.cc
src/icmp/IcmpSquid.cc
src/icmp/net_db.cc
src/icmp/pinger.cc
src/icp_v2.cc
src/icp_v3.cc
src/ident/AclIdent.cc
src/ip/Address.cc
src/ip/QosConfig.cc
src/ipc.cc
src/ipc/Coordinator.cc
src/ipc/FdNotes.cc
src/ipc/StoreMap.cc
src/ipc_win32.cc
src/ipcache.cc
src/log/File.cc
src/log/ModDaemon.cc
src/log/ModSyslog.cc
src/log/ModUdp.cc
src/log/TcpLogger.cc
src/mem/old_api.cc
src/mime.cc
src/multicast.cc
src/neighbors.cc
src/peer_digest.cc
src/peer_select.cc
src/redirect.cc
src/repl/heap/store_repl_heap.cc
src/security/Io.cc
src/security/PeerConnector.cc
src/security/PeerOptions.cc
src/security/ServerOptions.cc
src/security/Session.cc
src/send-announce.cc
src/servers/FtpServer.cc
src/snmp/Var.cc
src/ssl/ErrorDetailManager.cc
src/ssl/helper.cc
src/ssl/support.cc
src/stat.cc
src/stmem.cc
src/store/Controller.cc
src/store/Disks.cc
src/store_client.cc
src/store_swapin.cc
src/tools.cc
src/unlinkd.cc
src/wccp2.cc