]> git.ipfire.org Git - thirdparty/systemd.git/commit - src/systemctl/systemctl.c
systemctl: delay pager/polkit agent opening as much as possible 3546/head
authorZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Wed, 15 Jun 2016 13:11:32 +0000 (09:11 -0400)
committerZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Thu, 16 Jun 2016 13:30:18 +0000 (09:30 -0400)
commitd2ad7e1ba5c9e68367e0eedbbfdadfc3adf94af2
tree0322d4366f4a92cc2b9ccd5bb0436be2972428fa
parent33d52725f5e90f278fec675a8c34e3accaa6ad97
systemctl: delay pager/polkit agent opening as much as possible

In https://github.com/systemd/systemd/issues/3543, we would open the pager
before starting ssh, and the pipe fd was "leaked" into the ssh child as the
stderr fd. Previous commit fixes bus-socket to nullify stderr before launching
the child, but it seems reasonable to also delay starting the pager.
If we are going to croak when trying to open the transport, it seems better
to do this before starting the pager.

This commit would also fix #3543 on its own.
src/systemctl/systemctl.c