]> git.ipfire.org Git - thirdparty/qemu.git/commit - system/vl.c
vl: Improve error message for conflicting -incoming and -loadvm
authorKevin Wolf <kwolf@redhat.com>
Fri, 1 Dec 2023 14:25:19 +0000 (15:25 +0100)
committerKevin Wolf <kwolf@redhat.com>
Thu, 21 Dec 2023 21:49:27 +0000 (22:49 +0100)
commit5a7f21efaf99c60614fe1967be1c0f9aa46c526e
tree582b735415e1f265b9fd56f0884dac5bde1ba4ff
parentd3007d348adaaf04ee8b099a475282034a662414
vl: Improve error message for conflicting -incoming and -loadvm

Currently, the conflict between -incoming and -loadvm is only detected
when loading the snapshot fails because the image is still inactive for
the incoming migration. This results in a suboptimal error message:

$ ./qemu-system-x86_64 -hda /tmp/test.qcow2 -loadvm foo -incoming defer
qemu-system-x86_64: Device 'ide0-hd0' is writable but does not support snapshots

Catch the situation already in qemu_validate_options() to improve the
message:

$ ./qemu-system-x86_64 -hda /tmp/test.qcow2 -loadvm foo -incoming defer
qemu-system-x86_64: 'incoming' and 'loadvm' options are mutually exclusive

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20231201142520.32255-3-kwolf@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
system/vl.c