]> git.ipfire.org Git - thirdparty/git.git/commit - t/helper/test-dump-cache-tree.c
test-dump-cache-tree: avoid overflow of cache-tree name
authorJeff King <peff@peff.net>
Thu, 24 Sep 2015 21:06:03 +0000 (17:06 -0400)
committerJunio C Hamano <gitster@pobox.com>
Fri, 25 Sep 2015 17:18:18 +0000 (10:18 -0700)
commit04724222d5aad4da48674e69aab715273f05dded
treecd8923223008e3c6a652d5b6f8bb393fef7956ce
parent3131977de1476185209d4d56a0494f5b30ee5557
test-dump-cache-tree: avoid overflow of cache-tree name

When dumping a cache-tree, we sprintf sub-tree names directly
into a fixed-size buffer, which can overflow. We can
trivially fix this by converting to xsnprintf to at least
notice and die.

This probably should handle arbitrary-sized names, but
there's not much point. It's used only by the test scripts,
so the trivial fix is enough.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
test-dump-cache-tree.c