]> git.ipfire.org Git - thirdparty/git.git/commit - t/test-lib-github-workflow-markup.sh
ci(github): also skip logs of broken test cases
authorPhilippe Blain <levraiphilippeblain@gmail.com>
Sun, 21 Jan 2024 03:38:33 +0000 (03:38 +0000)
committerJunio C Hamano <gitster@pobox.com>
Mon, 22 Jan 2024 23:16:11 +0000 (15:16 -0800)
commit0188b2c8e015d0bb1b39bc396d38f3b73f2f8c34
tree222e8ddca525df3698ced7721bf7179b0fda5e47
parent564d0252ca632e0264ed670534a51d18a689ef5d
ci(github): also skip logs of broken test cases

When a test fails in the GitHub Actions CI pipeline, we mark it up using
special GitHub syntax so it stands out when looking at the run log. We
also mark up "fixed" test cases, and skip passing tests since we want to
concentrate on the failures.

The finalize_test_case_output function in
test-lib-github-workflow-markup.sh which performs this markup is however
missing a fourth case: "broken" tests, i.e. tests using
'test_expect_failure' to document a known bug. This leads to these
"broken" tests appearing along with any failed tests, potentially
confusing the reader who might not be aware that "broken" is the status
for 'test_expect_failure' tests that indeed failed, and wondering what
their commits "broke".

Also skip these "broken" tests so that only failures and fixed tests
stand out.

Signed-off-by: Philippe Blain <levraiphilippeblain@gmail.com>
Acked-by: Victoria Dye <vdye@github.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/test-lib-github-workflow-markup.sh