]> git.ipfire.org Git - thirdparty/linux.git/commit - tools/perf/util/annotate.c
perf annotate: Introduce strerror for handling symbol__disassemble() errors
authorArnaldo Carvalho de Melo <acme@redhat.com>
Fri, 29 Jul 2016 19:27:18 +0000 (16:27 -0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Mon, 1 Aug 2016 21:18:16 +0000 (18:18 -0300)
commitee51d851392e1fe3e8be30b3c5847f34da343424
tree995d0ca1d366d17876e5b8d32daef596941dacaa
parent5cb725a9723aebb248106ff7f8c6c7253b24bbb1
perf annotate: Introduce strerror for handling symbol__disassemble() errors

We were just using pr_error() which makes it difficult for non stdio UIs
to provide errors using its widgets, as they need to somehow catch what
was passed to pr_error().

Fix it by introducing a __strerror() interface like the ones used
elsewhere, for instance target__strerror().

This is just the initial step, more work will be done, but first some
error handling bugs noticed while working on this need to be dealt with.

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/n/tip-dgd22zl2xg7x4vcnoa83jxfb@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/builtin-top.c
tools/perf/ui/browsers/annotate.c
tools/perf/ui/gtk/annotate.c
tools/perf/util/annotate.c
tools/perf/util/annotate.h