]> git.ipfire.org Git - thirdparty/qemu.git/commit
qga-win: fix installation on localized windows
authorDaniel Rempel <daniel@daynix.com>
Wed, 5 Jul 2017 09:01:13 +0000 (12:01 +0300)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Mon, 17 Jul 2017 23:51:14 +0000 (18:51 -0500)
commit009f38d9858d4338ccaaef787a5d54fd1c4c9198
tree2fe8f4afad44656582d02d55bdd1357b2728a893
parentca4e667dbf431d4a2a5a619cde79d30dd2ac3eb2
qga-win: fix installation on localized windows

Bug: https://bugzilla.redhat.com/show_bug.cgi?id=1357789
Replace hardcoded user and group names ("Administrators", "SYSTEM") with the ones acquired from system. Windows uses localized strings for these names and it may cause the installation to fail.
Windows has Well-known SIDs for "Administrators" group and "SYSTEM" user so they were used to identify required users and groups.
Well-known SIDs: https://support.microsoft.com/en-us/help/243330/well-known-security-identifiers-in-windows-operating-systems

Signed-off-by: Daniel Rempel <daniel@daynix.com>
Signed-off-by: Sameeh Jubran <sjubran@redhat.com>
Reviewed-by: Sameeh Jubran <sameeh@daynix.com>
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
qga/vss-win32/install.cpp