]> git.ipfire.org Git - thirdparty/qemu.git/commit
virtio: Allow .get_vhost() without vhost_started
authorHanna Czenczek <hreitz@redhat.com>
Tue, 23 Jul 2024 16:39:39 +0000 (18:39 +0200)
committerMichael S. Tsirkin <mst@redhat.com>
Tue, 10 Sep 2024 18:27:56 +0000 (14:27 -0400)
commit00adced5c3166ee65b6880b48c1e0826b7304f76
treebc3b45eff027b2903d8a005788beaab13b5fd378
parenta66f28df650166ae8b50c992eea45e7b247f4143
virtio: Allow .get_vhost() without vhost_started

Historically, .get_vhost() was probably only called when
vdev->vhost_started is true.  However, we now decidedly want to call it
also when vhost_started is false, specifically so we can issue a reset
to the vhost back-end while device operation is stopped.

Some .get_vhost() implementations dereference some pointers (or return
offsets from them) that are probably guaranteed to be non-NULL when
vhost_started is true, but not necessarily otherwise.  This patch makes
all such implementations check all such pointers, returning NULL if any
is NULL.

Signed-off-by: Hanna Czenczek <hreitz@redhat.com>
Message-Id: <20240723163941.48775-2-hreitz@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
hw/display/vhost-user-gpu.c
hw/net/virtio-net.c
hw/virtio/virtio-crypto.c
include/hw/virtio/virtio.h