]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
scsi: virtio_scsi: limit number of hw queues by nr_cpu_ids
authorDongli Zhang <dongli.zhang@oracle.com>
Wed, 27 Mar 2019 10:36:35 +0000 (18:36 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 28 Nov 2023 16:45:46 +0000 (16:45 +0000)
commit0101448977efbeb2e35162d28ff8ec7bff2e5855
tree2a580d6e766125ac14b929e86327371626beccba
parent62a78cf03383630f21869ac0a1333389235d556d
scsi: virtio_scsi: limit number of hw queues by nr_cpu_ids

commit 1978f30a87732d4d9072a20abeded9fe17884f1b upstream.

When tag_set->nr_maps is 1, the block layer limits the number of hw queues
by nr_cpu_ids. No matter how many hw queues are used by virtio-scsi, as it
has (tag_set->nr_maps == 1), it can use at most nr_cpu_ids hw queues.

In addition, specifically for pci scenario, when the 'num_queues' specified
by qemu is more than maxcpus, virtio-scsi would not be able to allocate
more than maxcpus vectors in order to have a vector for each queue. As a
result, it falls back into MSI-X with one vector for config and one shared
for queues.

Considering above reasons, this patch limits the number of hw queues used
by virtio-scsi by nr_cpu_ids.

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Kunkun Jiang <jiangkunkun@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/scsi/virtio_scsi.c