]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
jbd2: fix compile warning when using JBUFFER_TRACE
authorzhangyi (F) <yi.zhang@huawei.com>
Thu, 21 Feb 2019 16:24:09 +0000 (11:24 -0500)
committerTheodore Ts'o <tytso@mit.edu>
Thu, 21 Feb 2019 16:24:09 +0000 (11:24 -0500)
commit01215d3edb0f384ddeaa5e4a22c1ae5ff634149f
tree8b7ff6039bd2b19023a8d6370dd591b0ed6b79ae
parent7159a986b4202343f6cca3bb8079ecace5816fd6
jbd2: fix compile warning when using JBUFFER_TRACE

The jh pointer may be used uninitialized in the two cases below and the
compiler complain about it when enabling JBUFFER_TRACE macro, fix them.

In file included from fs/jbd2/transaction.c:19:0:
fs/jbd2/transaction.c: In function ‘jbd2_journal_get_undo_access’:
./include/linux/jbd2.h:1637:38: warning: ‘jh’ is used uninitialized in this function [-Wuninitialized]
 #define JBUFFER_TRACE(jh, info) do { printk("%s: %d\n", __func__, jh->b_jcount);} while (0)
                                      ^
fs/jbd2/transaction.c:1219:23: note: ‘jh’ was declared here
  struct journal_head *jh;
                       ^
In file included from fs/jbd2/transaction.c:19:0:
fs/jbd2/transaction.c: In function ‘jbd2_journal_dirty_metadata’:
./include/linux/jbd2.h:1637:38: warning: ‘jh’ may be used uninitialized in this function [-Wmaybe-uninitialized]
 #define JBUFFER_TRACE(jh, info) do { printk("%s: %d\n", __func__, jh->b_jcount);} while (0)
                                      ^
fs/jbd2/transaction.c:1332:23: note: ‘jh’ was declared here
  struct journal_head *jh;
                       ^

Signed-off-by: zhangyi (F) <yi.zhang@huawei.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@vger.kernel.org
Reviewed-by: Jan Kara <jack@suse.cz>
fs/jbd2/transaction.c