]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
printk: Defer legacy printing when holding printk_cpu_sync
authorJohn Ogness <john.ogness@linutronix.de>
Mon, 9 Dec 2024 11:17:46 +0000 (12:23 +0106)
committerPetr Mladek <pmladek@suse.com>
Mon, 16 Dec 2024 12:26:31 +0000 (13:26 +0100)
commit0161e2d6950fe66cf6ac1c10d945bae971f33667
treee12087793cfe89c62446951321929beeb03ae651
parentf1c21cf470595c4561d4671fd499af94152175d5
printk: Defer legacy printing when holding printk_cpu_sync

The documentation of printk_cpu_sync_get() clearly states
that the owner must never perform any activities where it waits
for a CPU. For legacy printing there can be spinning on the
console_lock and on the port lock. Therefore legacy printing
must be deferred when holding the printk_cpu_sync.

Note that in the case of emergency states, atomic consoles
are not prevented from printing when printk is deferred. This
is appropriate because they do not spin-wait indefinitely for
other CPUs.

Reported-by: Rik van Riel <riel@surriel.com>
Closes: https://lore.kernel.org/r/20240715232052.73eb7fb1@imladris.surriel.com
Signed-off-by: John Ogness <john.ogness@linutronix.de>
Fixes: 55d6af1d6688 ("lib/nmi_backtrace: explicitly serialize banner and regs")
Reviewed-by: Petr Mladek <pmladek@suse.com>
Link: https://lore.kernel.org/r/20241209111746.192559-3-john.ogness@linutronix.de
Signed-off-by: Petr Mladek <pmladek@suse.com>
kernel/printk/internal.h
kernel/printk/printk.c
kernel/printk/printk_safe.c