]> git.ipfire.org Git - thirdparty/libvirt.git/commit
qemu: Enable I/O APIC even more frequently
authorMichal Privoznik <mprivozn@redhat.com>
Wed, 18 Dec 2024 10:07:26 +0000 (11:07 +0100)
committerMichal Privoznik <mprivozn@redhat.com>
Wed, 18 Dec 2024 14:27:12 +0000 (15:27 +0100)
commit0162f2008e36df489f6f04e4d6002543acfa171d
tree7cc989ab53665a3ae2b2ce7cfbc503d5d6c4e8ee
parentef7c0f46f9629f6bc9537703df5b78efc2d69ab0
qemu: Enable I/O APIC even more frequently

In my previous commit v10.10.0-48-g2d222ecf6e I've made us enable
I/O APIC when there is an IOMMU with EIM. This works well. What
does not work is case when there's just an IOMMU without EIM but
with 256+ vCPUS. Problem is that post parsing happens in two
stages: general domain post parse (where
qemuDomainDefEnableDefaultFeatures() is called) and then per
device post parse (where qemuDomainIOMMUDefPostParse() is
called). Now, in aforementioned case it is the device post parse
phase where EIM is enabled but the code that would enable
VIR_DOMAIN_FEATURE_IOAPIC has already run.

To resolve this, make the domain post parse callback "foresee"
the future enabling of EIM so that it can turn on I/O APIC
beforehand.

Resolves: https://issues.redhat.com/browse/RHEL-65844
Fixes: 2d222ecf6e73614a400b830ac56e9aaa1bc55ecc
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Jiri Denemark <jdenemar@redhat.com>
src/qemu/qemu_postparse.c
tests/qemuxmlconfdata/intel-iommu-eim-autoadd-v2.x86_64-latest.abi-update.args [new symlink]
tests/qemuxmlconfdata/intel-iommu-eim-autoadd-v2.x86_64-latest.abi-update.xml [new symlink]
tests/qemuxmlconfdata/intel-iommu-eim-autoadd-v2.xml [new file with mode: 0644]
tests/qemuxmlconftest.c