]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
drm/pixpaper: Fix return type of pixpaper_mode_valid()
authorNathan Chancellor <nathan@kernel.org>
Mon, 8 Sep 2025 20:24:59 +0000 (13:24 -0700)
committerThomas Zimmermann <tzimmermann@suse.de>
Mon, 15 Sep 2025 10:29:37 +0000 (12:29 +0200)
commit0265d0ebb409a25d3bb3a19494e0173d06d9d132
tree659391e5b540b6f989427ad0e9c895fb4857af87
parentb4d90dbc4c1bc4bd3eb2d2989330af0eb95c98e8
drm/pixpaper: Fix return type of pixpaper_mode_valid()

When building with -Wincompatible-function-pointer-types-strict, a
warning designed to catch kernel control flow integrity (kCFI) issues at
build time, there is an instance in the new tiny DRM pixpaper driver:

  drivers/gpu/drm/tiny/pixpaper.c:982:16: error: incompatible function pointer types initializing 'enum drm_mode_status (*)(struct drm_crtc *, const struct drm_display_mode *)' with an expression of type 'int (struct drm_crtc *, const struct drm_display_mode *)' [-Werror,-Wincompatible-function-pointer-types-strict]
    982 |         .mode_valid = pixpaper_mode_valid,
        |                       ^~~~~~~~~~~~~~~~~~~

While 'int' and 'enum drm_mode_status' are ABI compatible, hence no
regular warning from -Wincompatible-function-pointer-types, the mismatch
will trigger a kCFI violation when pixpaper_mode_valid() is called
indirectly.

Update the return type of pixpaper_mode_valid() to be
'enum drm_mode_status' to clear up the warning and kCFI violation.

Fixes: c9e70639f591 ("drm: tiny: Add support for Mayqueen Pixpaper e-ink panel")
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://lore.kernel.org/r/20250908-drm-pixpaper-fix-mode_valid-return-type-v1-1-705ceaf03757@kernel.org
drivers/gpu/drm/tiny/pixpaper.c