]> git.ipfire.org Git - thirdparty/qemu.git/commit
vhost-user: fix shared object return values
authorAlbert Esteve <aesteve@redhat.com>
Tue, 22 Oct 2024 12:46:14 +0000 (14:46 +0200)
committerMichael Tokarev <mjt@tls.msk.ru>
Fri, 20 Dec 2024 20:52:29 +0000 (23:52 +0300)
commit027cc19383a7afddcac56492b1bffc69e5d7f060
tree8a7b9e47fbdd9bbef6d297efe5900a41da5a6991
parent52e13e2ec7778bf8f6ea73a0f8a2638965ca78a1
vhost-user: fix shared object return values

VHOST_USER_BACKEND_SHARED_OBJECT_ADD and
VHOST_USER_BACKEND_SHARED_OBJECT_REMOVE state
in the spec that they return 0 for successful
operations, non-zero otherwise. However,
implementation relies on the return types
of the virtio-dmabuf library, with opposite
semantics (true if everything is correct,
false otherwise). Therefore, current
implementation violates the specification.

Revert the logic so that the implementation
of the vhost-user handling methods matches
the specification.

Fixes: 043e127a126bb3ceb5fc753deee27d261fd0c5ce
Fixes: 160947666276c5b7f6bca4d746bcac2966635d79
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Signed-off-by: Albert Esteve <aesteve@redhat.com>
Message-Id: <20241022124615.585596-1-aesteve@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
(cherry picked from commit eea5aeef84e1b74f515b474d3a86377701f93750)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
(Mjt: remove changes fixing v8.2.0-2279-g043e127a126b
 "hw/virtio: check owner for removing objects")
hw/virtio/vhost-user.c