]> git.ipfire.org Git - people/arne_f/kernel.git/commit
ALSA: hda/hdmi - add retry logic to parse_intel_hdmi()
authorKai Vehmanen <kai.vehmanen@linux.intel.com>
Mon, 20 Jan 2020 16:01:17 +0000 (18:01 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 28 Feb 2020 15:36:06 +0000 (16:36 +0100)
commit02b675041fcd930fd7d95b4e7bb68ddea4b21d9e
tree5ab9be9e2513ec7afb6304f5b4557ea97aa6c926
parentfb065f7bc0d378dda1b5e98d8afb22ccfc07e0aa
ALSA: hda/hdmi - add retry logic to parse_intel_hdmi()

[ Upstream commit 2928fa0a97ebb9549cb877fdc99aed9b95438c3a ]

The initial snd_hda_get_sub_node() can fail on certain
devices (e.g. some Chromebook models using Intel GLK).
The failure rate is very low, but as this is is part of
the probe process, end-user impact is high.

In observed cases, related hardware status registers have
expected values, but the node query still fails. Retrying
the node query does seem to help, so fix the problem by
adding retry logic to the query. This does not impact
non-Intel platforms.

BugLink: https://github.com/thesofproject/linux/issues/1642
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: Takashi Iwai <tiwai@suse.de>
Link: https://lore.kernel.org/r/20200120160117.29130-4-kai.vehmanen@linux.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/pci/hda/patch_hdmi.c