]> git.ipfire.org Git - thirdparty/gcc.git/commit
libstdc++: Fix std::basic_format_arg::handle for BasicFormatters
authorJonathan Wakely <jwakely@redhat.com>
Wed, 28 Feb 2024 15:05:08 +0000 (15:05 +0000)
committerJonathan Wakely <jwakely@redhat.com>
Thu, 29 Feb 2024 17:49:43 +0000 (17:49 +0000)
commit02ca9d3f0c5d2b0255df28f021834dd67ad79bc2
tree9c26841d63b75dcea44bb195f2872a57b69e669b
parentf5cdda8acb06c20335855ed353ab9a441c12128a
libstdc++: Fix std::basic_format_arg::handle for BasicFormatters

std::basic_format_arg::handle is supposed to format its value as const
if that is valid, to reduce the number of instantiations of the
formatter's format function. I made a silly typo so that it checks
formattable_with<TD, Context> not formattable_with<const TD, Context>,
which breaks support for BasicFormatters i.e. ones that can only format
non-const types.

There's a static_assert in the handle constructor which is supposed to
improve diagnostics for trying to format a const argument with a
formatter that doesn't support it. That condition can't fail, because
the std::basic_format_arg constructor is already constrained to check
that the argument type is formattable. The static_assert can be removed.

libstdc++-v3/ChangeLog:

* include/std/format (basic_format_arg::handle::__maybe_const_t):
Fix condition to check if const type is formattable.
(basic_format_arg::handle::handle(T&)): Remove redundant
static_assert.
* testsuite/std/format/formatter/basic.cc: New test.
libstdc++-v3/include/std/format
libstdc++-v3/testsuite/std/format/formatter/basic.cc [new file with mode: 0644]