]> git.ipfire.org Git - thirdparty/libvirt.git/commit
nwfilter: grab driver lock earlier during init (bz96649)
authorStefan Berger <stefanb@linux.vnet.ibm.com>
Tue, 4 Jun 2013 18:50:20 +0000 (14:50 -0400)
committerCole Robinson <crobinso@redhat.com>
Wed, 12 Jun 2013 19:22:43 +0000 (15:22 -0400)
commit0305c271fcfcf7478cb96c36727253259a982355
treeda73609248c162d2d05048752917d049f2e0d6ec
parent364bbdc4cc274abaeadef322bc99703a626574d7
nwfilter: grab driver lock earlier during init (bz96649)

This patch is in relation to Bug 966449:

https://bugzilla.redhat.com/show_bug.cgi?id=966449

This is a patch addressing the coredump.

Thread 1 must be calling  nwfilterDriverRemoveDBusMatches(). It does so with
nwfilterDriverLock held. In the patch below I am now moving the
nwfilterDriverLock(driverState) further up so that the initialization, which
seems to either take a long time or is entirely stuck, occurs with the lock
held and the shutdown cannot occur at the same time.

Remove the lock in virNWFilterDriverIsWatchingFirewallD to avoid
double-locking.

(cherry picked from commit 0ec376c20a42b9eb365c1f9a5596366023c20c35)
src/nwfilter/nwfilter_driver.c