]> git.ipfire.org Git - thirdparty/openvpn.git/commit
tun.c: don't attempt to delete DNS and WINS servers if they're not set
authorLev Stipakov <lev@openvpn.net>
Wed, 20 Dec 2023 13:36:37 +0000 (14:36 +0100)
committerGert Doering <gert@greenie.muc.de>
Thu, 21 Dec 2023 13:16:17 +0000 (14:16 +0100)
commit030afe64198e6c32297dcdbf33ff9c5f6a35f5e1
treec8286de31405a0f47889489ca04e2a9d9ce138e3
parente2a9c1ba947fbe18af124583cc30eb1b2bd2aab0
tun.c: don't attempt to delete DNS and WINS servers if they're not set

Commits

    1c4a47f7 ("wintun: set adapter properties via interactive service")
    18826de5 ("Set WINS servers via interactice service")

added functionality of add/remove DNS/WINS via interactive
service, which is used mostly by dco-win and wintun (tap-windows6
normally uses DHCP). There is a check in code - if DNS/WINS addresses
are not pushed, nothing is added.

However, due to bug we always attempted to remove DNS/WINS,
even if nothing was added. Removing WINS, for example, could take
up to 3 seconds.

This change fixes this by improving check "has DNS/WINS been pushed?".

While on it, convert do_XXX_service() functions to "void" from "bool",
since we never check their return values.

Change-Id: I21a36d24f8e213c780f55acbe3e4df555c93542a
Signed-off-by: Lev Stipakov <lev@openvpn.net>
Acked-by: Frank Lichtenheld <frank@lichtenheld.com>
Message-Id: <20231220133637.60996-1-frank@lichtenheld.com>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27843.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
(cherry picked from commit c590868a721881dd21bfb77ecf846e6c8720e4ef)
src/openvpn/tun.c