]> git.ipfire.org Git - people/arne_f/kernel.git/commit
tracing: Do not free iter->trace in fail path of tracing_open_pipe()
authorzhangyi (F) <yi.zhang@huawei.com>
Wed, 13 Feb 2019 12:29:06 +0000 (20:29 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 23 Mar 2019 12:19:45 +0000 (13:19 +0100)
commit037a6cf0d5d3422206321649e5fe4c5f03d06ba9
tree7610f5b609bbb3c8248f73a41b1e09c3997018a9
parent286ffaa029fe44a05c06505ca8804716108113cc
tracing: Do not free iter->trace in fail path of tracing_open_pipe()

commit e7f0c424d0806b05d6f47be9f202b037eb701707 upstream.

Commit d716ff71dd12 ("tracing: Remove taking of trace_types_lock in
pipe files") use the current tracer instead of the copy in
tracing_open_pipe(), but it forget to remove the freeing sentence in
the error path.

There's an error path that can call kfree(iter->trace) after the iter->trace
was assigned to tr->current_trace, which would be bad to free.

Link: http://lkml.kernel.org/r/1550060946-45984-1-git-send-email-yi.zhang@huawei.com
Cc: stable@vger.kernel.org
Fixes: d716ff71dd12 ("tracing: Remove taking of trace_types_lock in pipe files")
Signed-off-by: zhangyi (F) <yi.zhang@huawei.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
kernel/trace/trace.c