]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
wifi: libertas: fix use-after-free in lbs_free_adapter()
authorDaniel Hodges <git@danielhodges.dev>
Fri, 6 Feb 2026 19:53:56 +0000 (14:53 -0500)
committerJohannes Berg <johannes.berg@intel.com>
Mon, 23 Feb 2026 08:28:14 +0000 (09:28 +0100)
commit03cc8f90d0537fcd4985c3319b4fafbf2e3fb1f0
tree3406132a1eca7b508ba4011f65ea73fc4ad70dcc
parent25723454f67980712234a42caca606b6710fd1e1
wifi: libertas: fix use-after-free in lbs_free_adapter()

The lbs_free_adapter() function uses timer_delete() (non-synchronous)
for both command_timer and tx_lockup_timer before the structure is
freed. This is incorrect because timer_delete() does not wait for
any running timer callback to complete.

If a timer callback is executing when lbs_free_adapter() is called,
the callback will access freed memory since lbs_cfg_free() frees the
containing structure immediately after lbs_free_adapter() returns.

Both timer callbacks (lbs_cmd_timeout_handler and lbs_tx_lockup_handler)
access priv->driver_lock, priv->cur_cmd, priv->dev, and other fields,
which would all be use-after-free violations.

Use timer_delete_sync() instead to ensure any running timer callback
has completed before returning.

This bug was introduced in commit 8f641d93c38a ("libertas: detect TX
lockups and reset hardware") where del_timer() was used instead of
del_timer_sync() in the cleanup path. The command_timer has had the
same issue since the driver was first written.

Fixes: 8f641d93c38a ("libertas: detect TX lockups and reset hardware")
Fixes: 954ee164f4f4 ("[PATCH] libertas: reorganize and simplify init sequence")
Cc: stable@vger.kernel.org
Signed-off-by: Daniel Hodges <git@danielhodges.dev>
Link: https://patch.msgid.link/20260206195356.15647-1-git@danielhodges.dev
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
drivers/net/wireless/marvell/libertas/main.c