]> git.ipfire.org Git - thirdparty/linux.git/commit
drm/amdgpu: fix the logic to validate fpriv and root bo
authorSunil Khatri <sunil.khatri@amd.com>
Wed, 9 Jul 2025 07:16:18 +0000 (12:46 +0530)
committerChristian König <christian.koenig@amd.com>
Wed, 9 Jul 2025 08:15:30 +0000 (10:15 +0200)
commit03d5236014a5d298c26b2ca80e5834aa844574b3
treed2e91b7c92cd5f31f82d89c77771f02835e536ca
parent8f9abaff41de5b5f977b6d0372073563241cb5df
drm/amdgpu: fix the logic to validate fpriv and root bo

Fix the smatch warning,
smatch warnings:
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:2146 amdgpu_pt_info_read()
error: we previously assumed 'fpriv' could be null (see line 2146)

"if (!fpriv && !fpriv->vm.root.bo)", It has to be an OR condition
rather than an AND which makes an NULL dereference in case fpriv is NULL.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202507090525.9rDWGhz3-lkp@intel.com/
Signed-off-by: Sunil Khatri <sunil.khatri@amd.com>
Link: https://lore.kernel.org/r/20250709071618.591866-1-sunil.khatri@amd.com
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Christian König <christian.koenig@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c