]> git.ipfire.org Git - thirdparty/libvirt.git/commit
storagepoolxml2argvtest: Reorder gluster arguments
authorRoman Bolshakov <r.bolshakov@yadro.com>
Tue, 3 Nov 2020 14:26:30 +0000 (17:26 +0300)
committerAndrea Bolognani <abologna@redhat.com>
Wed, 4 Nov 2020 10:54:03 +0000 (11:54 +0100)
commit040de3fe4643a2e859f22e31415e479e99e52347
tree0ffa5221df75594945fae59035a2c59d287809c5
parentbeece2411d6e61718e4be4b4d6acce6154cde2b6
storagepoolxml2argvtest: Reorder gluster arguments

Commit f00cde7f1133 changed order of mount arguments in
virStorageBackendFileSystemMountGlusterArgs() and introduced per-OS
mount options and new test data. Old test data was left unmodified with
prior order of arguments. That causes a test failure on all OSes but
Linux and FreeBSD, i.e. on macOS:

  15) Storage Pool XML-2-argv pool-netfs-gluster
      ...
  In
  '/Users/roolebo/dev/libvirt/tests/storagepoolxml2argvdata/pool-netfs-gluster.argv':
  Offset 39
  Expect [-o direct-io-mode=1 /mnt/gluster]
  Actual [/mnt/gluster -o direct-io-mode=1]

Fixes: f00cde7f1133 ("storage: Add default mount options for fs/netfs storage pools")
Signed-off-by: Roman Bolshakov <r.bolshakov@yadro.com>
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
tests/storagepoolxml2argvdata/pool-netfs-gluster.argv